Add Shard Information Display to Ledger Accounts#1717
Add Shard Information Display to Ledger Accounts#1717arhtudormorar merged 4 commits intodevelopmentfrom
Conversation
… enhance updateAccountsList function to include shard information for Ledger accounts
…for version 5.6.9
Summary of ChangesHello @arhtudormorar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Ledger account management functionality by introducing the display of shard information. This change provides users with greater transparency regarding their account's distribution within the network, aligning with recent updates in the SDK dApp UI and improving the overall user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully introduces the display of shard information for Ledger accounts, aligning with the described enhancements. The dependency updates in package.json and pnpm-lock.yaml are consistent with the new functionality, and the CHANGELOG.md has been updated accordingly. The implementation correctly integrates Address and AddressComputer from sdkCore to derive and store shard data within the ILedgerAccount interface. The changes are well-contained and directly address the stated objective.
* Update optional dependency @multiversx/sdk-dapp-ui to version 0.1.16; enhance updateAccountsList function to include shard information for Ledger accounts * Update sdk-dapp-ui dependency to version 0.1.17; add changelog entry for version 5.6.9 * 5.6.9 * Add shard information to account objects in updateAccountsList tests
1 participant
Add Shard Information Display to Ledger Accounts
Description
This PR enhances the Ledger account management functionality by adding shard information display for Ledger accounts, complementing the recent SDK dApp UI updates.
Changes
updateAccountsListfunction to include shard information for Ledger accounts@multiversx/sdk-dapp-uito version 0.1.17 for UI component supportWhy
This change improves the user experience when managing Ledger accounts by providing transparency about account sharding, which is essential for understanding account distribution across the network.
Testing
Related Issues
Breaking Changes
None
Deployment Notes
Checklist