Skip to content

5.6.9#1718

Merged
arhtudormorar merged 1 commit intomainfrom
development
Jan 27, 2026
Merged

5.6.9#1718
arhtudormorar merged 1 commit intomainfrom
development

Conversation

@arhtudormorar
Copy link
Copy Markdown
Contributor

  • Update optional dependency @multiversx/sdk-dapp-ui to version 0.1.16; enhance updateAccountsList function to include shard information for Ledger accounts

  • Update sdk-dapp-ui dependency to version 0.1.17; add changelog entry for version 5.6.9

  • 5.6.9

  • Add shard information to account objects in updateAccountsList tests

Issue/Feature

Reproduce

Issue exists on version 2. of sdk-dapp.

Root cause

Fix

Additional changes

Contains breaking changes

  • No
  • Yes

Updated CHANGELOG

  • No
  • Yes

Testing

  • User testing
  • Unit tests

* Update optional dependency @multiversx/sdk-dapp-ui to version 0.1.16; enhance updateAccountsList function to include shard information for Ledger accounts

* Update sdk-dapp-ui dependency to version 0.1.17; add changelog entry for version 5.6.9

* 5.6.9

* Add shard information to account objects in updateAccountsList tests
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the sdk-dapp library by updating a key optional dependency, @multiversx/sdk-dapp-ui, to its latest version. Concurrently, it introduces a significant improvement for Ledger users by integrating shard information directly into their account details. This ensures that applications built with sdk-dapp can accurately display and utilize the correct shard for Ledger-connected accounts, improving user experience and compatibility with the MultiversX blockchain's sharded architecture.

Highlights

  • Dependency Update: The optional dependency @multiversx/sdk-dapp-ui has been updated to version 0.1.17.
  • Ledger Account Shard Information: The updateAccountsList function for Ledger accounts now includes logic to compute and store the blockchain shard associated with each account. This is achieved by importing Address and AddressComputer from lib/sdkCore and utilizing getShardOfAddress.
  • Interface Enhancement: The ILedgerAccount interface in ledger.types.ts has been extended to include an optional shard property, which can be a number or null.
  • Test Coverage: Unit tests for updateAccountsList have been updated to assert the presence and correctness of the new shard property in Ledger account objects.
  • Version Bump and Changelog: The project version has been incremented to 5.6.9 in package.json, and a corresponding entry has been added to CHANGELOG.md.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the @multiversx/sdk-dapp-ui optional dependency to version 0.1.17 and introduces functionality to include shard information for Ledger accounts. The changes are well-implemented across package.json, pnpm-lock.yaml, the updateAccountsList helper, and the ILedgerAccount type definition. Corresponding tests have also been updated to reflect these changes, ensuring correctness and consistency.

@arhtudormorar arhtudormorar merged commit d715ae8 into main Jan 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants