wasmer prod instance - set_breakpoint_value_legacy fix#89
Merged
andrei-marinica merged 2 commits intomasterfrom Apr 17, 2026
Merged
wasmer prod instance - set_breakpoint_value_legacy fix#89andrei-marinica merged 2 commits intomasterfrom
andrei-marinica merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes how legacy breakpoint values are set on the Wasmer production instance state by using the legacy breakpoint type directly (instead of converting from the “new” breakpoint type), aligning with the underlying InstanceLegacy::set_breakpoint_value API.
Changes:
- Update
WasmerProdInstanceState::set_breakpoint_value_legacyto acceptBreakpointValueLegacy. - Pass the legacy value directly to
WasmerInstance::set_breakpoint_value(removeto_legacy()conversion). - Adjust imports accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Fixes how legacy breakpoint values are set on the Wasmer production instance state by using the legacy breakpoint type directly (instead of converting from the “new” breakpoint type), aligning with the underlying
InstanceLegacy::set_breakpoint_valueAPI.Changes:
WasmerProdInstanceState::set_breakpoint_value_legacyto acceptBreakpointValueLegacy.WasmerInstance::set_breakpoint_value(removeto_legacy()conversion).Compatibility
The
wasmer-prodcrate is not released, it is imported in the Rust VM via git hash. Methodset_breakpoint_value_legacyis only used there. See multiversx/mx-sdk-rs#2348