Backport "Merge PR #7133: FIX(server): Handle WinAPI objects lifetime properly in Zeroconf" to 1.5.x#7208
Draft
Hartmnt wants to merge 2 commits into
Draft
Backport "Merge PR #7133: FIX(server): Handle WinAPI objects lifetime properly in Zeroconf" to 1.5.x#7208Hartmnt wants to merge 2 commits into
Hartmnt wants to merge 2 commits into
Conversation
Recently we received multiple reports of random server crashes. Turns out DnsServiceDeRegister(), more specifically svcRegDeregMulticast(), now reads the content of the DNS_SERVICE_INSTANCE object that is indirectly passed to it. I've confirmed this by comparing dnsapi.dll version 10.0.26100.7920 to version 10.0.10240.16384. This commit almost completely refactors the Windows-specific code making it more efficient and readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7133