Skip to content

Update MKUser.h#30

Open
vodaion wants to merge 1 commit into
mumble-voip:masterfrom
vodaion:patch-1
Open

Update MKUser.h#30
vodaion wants to merge 1 commit into
mumble-voip:masterfrom
vodaion:patch-1

Conversation

@vodaion
Copy link
Copy Markdown

@vodaion vodaion commented Dec 11, 2014

Fix error: Cannot find interface declaration for 'NSObject', superclass of 'MKUser'

Fix error: Cannot find interface declaration for 'NSObject', superclass of 'MKUser'
@mkrautz
Copy link
Copy Markdown
Contributor

mkrautz commented Dec 11, 2014

Hi @vadeara,

Thank you very much for the patch.

The reason the headers don't include Foundation.h is that both MumbleKit and Mumble for iOS have Foundation.h in their precompiled headers list.

Obviously, this doesn't necessarily work for other apps. However, instead of adding Foundation.h headers to all headers in the MumbleKit module, I think that we should encourage a single header for the module, <MumbleKit/MumbleKit.h>. This header includes all the MK*.h headers, but also ensures that Foundation.h and other deps are included before them.

So, I'll NAK this incarnation of the patch. Are you interested in contributing a MumbleKit.h header as described above? If not, I'll do it myself. :-)

@fridtjof fridtjof mentioned this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants