-
Notifications
You must be signed in to change notification settings - Fork 28
👷 Enable testing on Python 3.14 #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Edit: We are now waiting for a |
df4f3fe to
1ecda3e
Compare
16cd0a4 to
acdd231
Compare
acdd231 to
acdafcb
Compare
|
As all dependencies are finally updated, this should be ready to go. 🎉 |
burgholzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Cool to see this finally enabled 🙌
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR enables Python 3.14 testing support by extending the nox test matrix to include version 3.14, adding Python 3.14-specific dependency constraints, updating the changelog, and correcting a GitHub Actions workflow syntax issue in the attestation step. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 55-65: The pyproject entry pins "multiprocess>=0.70.19;
python_version >= '3.14'" which is not available for CPython 3.14 and will break
installs; update the multiprocess dependency in pyproject.toml by removing the
Python 3.14 conditional and keeping a single compatible requirement (e.g., keep
"multiprocess>=0.70.17" or simply "multiprocess>=0.70.17" replacing both
multiprocess lines), or if you need a newer feature, find a multiprocess release
that actually provides cp314 wheels and pin to that version instead; edit the
multiprocess lines in the dependency list to reflect the chosen compatible
requirement.
|
Celebrated too early... 🫠 For the CI to pass also on Windows, we need a new release of Back to draft. 😞 |
Damn. Can we open issue in both to drive this? Or PRs if that's even easier? |
I have opened oscarhiggott/PyMatching#179 to address the first issue. Once this change is released, I'll follow up on the |
Description
This PR enables testing on Python 3.14.
Fixes #464
Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added migration instructions to the upgrade guide (if needed).