Implement DAP for muon#251
Draft
annacrombie wants to merge 21 commits into
Draft
Conversation
all breaking is now done with a single bytecode instruction: op_dbg_break This means that the vm doesn't need to poll all breakpoints before executing each instruction, but stepping is a little more complicated. This is still kinda broken
So that you can line them up with output from the running vm
Allows front ends pause on the first line.
Bring back command line debugging since I feel like it is still somewhat useful. Since the DAP flag is more of an internal thing (users won't typically be typing it on the command line), use capital B for it.
This makes breakpoint resolution consistent.
It was being set wrong anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also comes with overall debugging improvements, including lots to how stepping works.