Skip to content

Conversation

@pacebes
Copy link
Contributor

@pacebes pacebes commented Nov 27, 2025

Resolves: #24813

  • Creates a new module to deal with exporting LRC files
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@pacebes pacebes force-pushed the 24813-ExportLRCLyricsFiles branch 3 times, most recently from 42deef3 to eedfcc3 Compare November 30, 2025 10:35
@cbjeukendrup cbjeukendrup force-pushed the 24813-ExportLRCLyricsFiles branch from 2022588 to ac8e8f9 Compare November 30, 2025 16:33
Copy link
Member

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a number of review fixes myself; here's one more thing to consider:

@pacebes pacebes force-pushed the 24813-ExportLRCLyricsFiles branch from ac8e8f9 to 5a6404c Compare November 30, 2025 17:11
@pacebes pacebes force-pushed the 24813-ExportLRCLyricsFiles branch from 179fa34 to e22bc62 Compare November 30, 2025 19:52
@pacebes pacebes force-pushed the 24813-ExportLRCLyricsFiles branch from e22bc62 to 19483e8 Compare December 6, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement exporting of LRC lyric files

2 participants