fix(properties): empty playback popup #31358
Open
+125
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause: the required property `model` was not properly set in the instantiation of `NoteExpandableBlank` etc.. Apparently, in the case of Loader, properties of the Loader are not automatically assigned to required properties of the source component; they are only passed as context properties, which we can't use with `ComponentBehaviour: Bound`. Solution: pass the property directly where the components are declared. This does require moving the component declarations into the Loader, because only there the model in question is available. That in turn required a slight refactor of `fullModel` and `getVisibleModel`. This is combined with a refactor that eliminates PlaybackGeneralSettings, because it is the only child of PlaybackSettings, so everything can just as well be directly in PlaybackSettings. And a tiny runtime warning fix in `NotationMultiElementView`.
Contributor
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause: the required property
modelwas not properly set in the instantiation ofNoteExpandableBlanketc.. Apparently, in the case of Loader, properties of the Loader are not automatically assigned to required properties of the source component; they are only passed as context properties, which we can't use withComponentBehaviour: Bound.Solution: pass the property directly where the components are declared. This does require moving the component declarations into the Loader, because only there the model in question is available. That in turn required a slight refactor of
fullModelandgetVisibleModel.This is combined with a refactor that eliminates PlaybackGeneralSettings, because it is the only child of PlaybackSettings, so everything can just as well be directly in PlaybackSettings.
And a tiny runtime warning fix in
NotationMultiElementView.For QA: just need to check that the playback popup in the properties panel appears correctly for notes, arpeggios, fermatas, breaths, glissandos and gradual tempo changes. (for other elements it should be disabled)