Fix MSVC compiler warnings #31361
Open
Fix MSVC compiler warnings #31361
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Dec 5, 2025
Jojo-Schmitz
commented
- reg.: 'argument': conversion from 'size_t' to 'int', possible loss of data (C4267)
- reg.: unreachable code (C4702)
Jojo-Schmitz
commented
Dec 5, 2025
| return module; | ||
| } | ||
|
|
||
| bool ApiDumpModel::isAllowByType(const QString& module, ApiType type) const |
Contributor
Author
There was a problem hiding this comment.
Shouldn't that rather be named isAllowedByType()?
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
2 times, most recently
from
f5491e1 to
f466e4d
Compare
cbjeukendrup
reviewed
Dec 5, 2025
| } | ||
|
|
||
| bool ApiDumpModel::isAllowByType(const QString& module, ApiType type) const | ||
| bool ApiDumpModel::isAllowedByType(const QString& module, ApiType type) const |
Member
There was a problem hiding this comment.
Now it complains about unused parameters
Contributor
Author
There was a problem hiding this comment.
Ah, of course. I'll fix it, tomorrow
cbjeukendrup
reviewed
Dec 5, 2025
| bool ApiDumpModel::isAllowedByType(const QString& module, ApiType type) const | ||
| { | ||
| #if 1 | ||
| return true; |
Member
There was a problem hiding this comment.
@igorkorsukov maybe this return true was not meant to be committed? Or maybe it's still work in progress?
Contributor
There was a problem hiding this comment.
Sorry, that was a quick fix. I need to tweak this model a bit. I'll do it on Monday.
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
3 times, most recently
from
4e13b3c to
ccdd559
Compare
reg.: 'argument': conversion from 'size_t' to 'int', possible loss of data (C4267)
reg.: unreachable code (C4702) and fix naming
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
ccdd559 to
ee2f6db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.