Skip to content

Fix #23502: Do not duplicate text for note names plugin #31365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XiaoMigros wants to merge 1 commit into
base: master
Choose a base branch
from
+132 −181
Open

Fix #23502: Do not duplicate text for note names plugin #31365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
313 changes: 132 additions & 181 deletions share/plugins/note_names/notenames.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
// Copyright (C) 2013 - 2021 Joachim Schmitz
// Copyright (C) 2014 Jörn Eichler
// Copyright (C) 2020 Johan Temmerman
// Copyright (C) 2025 XiaoMigros
//
// This program is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License version 2
Expand All @@ -19,191 +20,141 @@ import QtQuick 2.2
import MuseScore 3.0

MuseScore {
version: "4.0"
version: "4.7"
description: "This plugin names notes as per your language setting"
title: "Note Names"
categoryCode: "composing-arranging-tools"
thumbnailName: "note_names.png"

// Small note name size is fraction of the full font size.
property real fontSizeMini: 0.7;

function nameChord (notes, text, small) {
var sep = "\n"; // change to "," if you want them horizontally (anybody?)
var oct = "";
var name;
for (var i = 0; i < notes.length; i++) {
if (!notes[i].visible)
continue // skip invisible notes
if (text.text) // only if text isn't empty
text.text = sep + text.text;
if (small)
text.fontSize *= fontSizeMini
if (typeof notes[i].tpc === "undefined") // like for grace notes ?!?
return
switch (notes[i].tpc) {
case -1: name = qsTranslate("global", "F♭♭"); break;
case 0: name = qsTranslate("global", "C♭♭"); break;
case 1: name = qsTranslate("global", "G♭♭"); break;
case 2: name = qsTranslate("global", "D♭♭"); break;
case 3: name = qsTranslate("global", "A♭♭"); break;
case 4: name = qsTranslate("global", "E♭♭"); break;
case 5: name = qsTranslate("global", "B♭♭"); break;

case 6: name = qsTranslate("global", "F♭"); break;
case 7: name = qsTranslate("global", "C♭"); break;
case 8: name = qsTranslate("global", "G♭"); break;
case 9: name = qsTranslate("global", "D♭"); break;
case 10: name = qsTranslate("global", "A♭"); break;
case 11: name = qsTranslate("global", "E♭"); break;
case 12: name = qsTranslate("global", "B♭"); break;

case 13: name = qsTranslate("global", "F"); break;
case 14: name = qsTranslate("global", "C"); break;
case 15: name = qsTranslate("global", "G"); break;
case 16: name = qsTranslate("global", "D"); break;
case 17: name = qsTranslate("global", "A"); break;
case 18: name = qsTranslate("global", "E"); break;
case 19: name = qsTranslate("global", "B"); break;

case 20: name = qsTranslate("global", "F♯"); break;
case 21: name = qsTranslate("global", "C♯"); break;
case 22: name = qsTranslate("global", "G♯"); break;
case 23: name = qsTranslate("global", "D♯"); break;
case 24: name = qsTranslate("global", "A♯"); break;
case 25: name = qsTranslate("global", "E♯"); break;
case 26: name = qsTranslate("global", "B♯"); break;

case 27: name = qsTranslate("global", "F♯♯"); break;
case 28: name = qsTranslate("global", "C♯♯"); break;
case 29: name = qsTranslate("global", "G♯♯"); break;
case 30: name = qsTranslate("global", "D♯♯"); break;
case 31: name = qsTranslate("global", "A♯♯"); break;
case 32: name = qsTranslate("global", "E♯♯"); break;
case 33: name = qsTranslate("global", "B♯♯"); break;

default: name = qsTr("?") + text.text; break;
} // end switch tpc

// octave, middle C being C4
//oct = (Math.floor(notes[i].pitch / 12) - 1)
// or
//oct = (Math.floor(notes[i].ppitch / 12) - 1)
// or even this, similar to the Helmholtz system but one octave up
//var octaveTextPostfix = [",,,,,", ",,,,", ",,,", ",,", ",", "", "'", "''", "'''", "''''", "'''''"];
//oct = octaveTextPostfix[Math.floor(notes[i].pitch / 12)];
text.text = name + oct + text.text
} // end for note
}

function renderGraceNoteNames (cursor, list, text, small) {
if (list.length > 0) { // Check for existence.
// Now render grace note's names...
for (var chordNum = 0; chordNum < list.length; chordNum++) {
// iterate through all grace chords
var chord = list[chordNum];
// Set note text, grace notes are shown a bit smaller
nameChord(chord.notes, text, small)
if (text.text)
cursor.add(text)
// X position the note name over the grace chord
text.offsetX = chord.posX
switch (cursor.voice) {
case 1: case 3: text.placement = Placement.BELOW; break;
function nameNote(note) {
switch (note.tpc) {
case -8: return qsTranslate("global", "F♭♭♭")
case -7: return qsTranslate("global", "C♭♭♭")
case -6: return qsTranslate("global", "G♭♭♭")
case -5: return qsTranslate("global", "D♭♭♭")
case -4: return qsTranslate("global", "A♭♭♭")
case -3: return qsTranslate("global", "E♭♭♭")
case -2: return qsTranslate("global", "B♭♭♭")

case -1: return qsTranslate("global", "F♭♭")
case 0: return qsTranslate("global", "C♭♭")
case 1: return qsTranslate("global", "G♭♭")
case 2: return qsTranslate("global", "D♭♭")
case 3: return qsTranslate("global", "A♭♭")
case 4: return qsTranslate("global", "E♭♭")
case 5: return qsTranslate("global", "B♭♭")

case 6: return qsTranslate("global", "F♭")
case 7: return qsTranslate("global", "C♭")
case 8: return qsTranslate("global", "G♭")
case 9: return qsTranslate("global", "D♭")
case 10: return qsTranslate("global", "A♭")
case 11: return qsTranslate("global", "E♭")
case 12: return qsTranslate("global", "B♭")

case 13: return qsTranslate("global", "F")
case 14: return qsTranslate("global", "C")
case 15: return qsTranslate("global", "G")
case 16: return qsTranslate("global", "D")
case 17: return qsTranslate("global", "A")
case 18: return qsTranslate("global", "E")
case 19: return qsTranslate("global", "B")

case 20: return qsTranslate("global", "F♯")
case 21: return qsTranslate("global", "C♯")
case 22: return qsTranslate("global", "G♯")
case 23: return qsTranslate("global", "D♯")
case 24: return qsTranslate("global", "A♯")
case 25: return qsTranslate("global", "E♯")
case 26: return qsTranslate("global", "B♯")

case 27: return qsTranslate("global", "F♯♯")
case 28: return qsTranslate("global", "C♯♯")
case 29: return qsTranslate("global", "G♯♯")
case 30: return qsTranslate("global", "D♯♯")
case 31: return qsTranslate("global", "A♯♯")
case 32: return qsTranslate("global", "E♯♯")
case 33: return qsTranslate("global", "B♯♯")

case 34: return qsTranslate("global", "F♯♯")
case 35: return qsTranslate("global", "C♯♯♯")
case 36: return qsTranslate("global", "G♯♯♯")
case 37: return qsTranslate("global", "D♯♯♯")
case 38: return qsTranslate("global", "A♯♯♯")
case 39: return qsTranslate("global", "E♯♯♯")
case 40: return qsTranslate("global", "B♯♯♯")

default: return qsTr("?")
}
}

onRun: {
if (curScore.selection.elements.length == 0) {
curScore.startCmd("Add note names to score")
cmd("select-all")
} else {
curScore.startCmd("Add note names selection")
}

// Get list of chords (saves calculations)
var chordList = []
for (var el of curScore.selection.elements) {
if (el.type == Element.NOTE && el.parent.type == Element.CHORD) {
var add = true
for (var chord of chordList) {
if (chord.is(el.parent)) {
add = false
break
}
}
if (add) {
chordList.push(el.parent)
}
}

// If we consume a STAFF_TEXT we must manufacture a new one.
if (text.text)
text = newElement(Element.STAFF_TEXT); // Make another STAFF_TEXT
}
}
return text
}

onRun: {
curScore.startCmd()

var cursor = curScore.newCursor();
var startStaff;
var endStaff;
var endTick;
var fullScore = false;
cursor.rewind(1);
if (!cursor.segment) { // no selection
fullScore = true;
startStaff = 0; // start with 1st staff
endStaff = curScore.nstaves - 1; // and end with last
} else {
startStaff = cursor.staffIdx;
cursor.rewind(2);
if (cursor.tick === 0) {
// this happens when the selection includes
// the last measure of the score.
// rewind(2) goes behind the last segment (where
// there's none) and sets tick=0
endTick = curScore.lastSegment.tick + 1;
} else {
endTick = cursor.tick;
}
endStaff = cursor.staffIdx;
}
console.log(startStaff + " - " + endStaff + " - " + endTick)

for (var staff = startStaff; staff <= endStaff; staff++) {
for (var voice = 0; voice < 4; voice++) {
cursor.rewind(1); // beginning of selection
cursor.voice = voice;
cursor.staffIdx = staff;

if (fullScore) // no selection
cursor.rewind(0); // beginning of score
while (cursor.segment && (fullScore || cursor.tick < endTick)) {
if (cursor.element && cursor.element.type === Element.CHORD) {
var text = newElement(Element.STAFF_TEXT); // Make a STAFF_TEXT

// First...we need to scan grace notes for existence and break them
// into their appropriate lists with the correct ordering of notes.
var leadingLifo = Array(); // List for leading grace notes
var trailingFifo = Array(); // List for trailing grace notes
var graceChords = cursor.element.graceNotes;
// Build separate lists of leading and trailing grace note chords.
if (graceChords.length > 0) {
for (var chordNum = 0; chordNum < graceChords.length; chordNum++) {
var noteType = graceChords[chordNum].notes[0].noteType
if (noteType === NoteType.GRACE8_AFTER || noteType === NoteType.GRACE16_AFTER ||
noteType === NoteType.GRACE32_AFTER) {
trailingFifo.unshift(graceChords[chordNum])
} else {
leadingLifo.push(graceChords[chordNum])
}
}
}

// Next process the leading grace notes, should they exist...
text = renderGraceNoteNames(cursor, leadingLifo, text, true)

// Now handle the note names on the main chord...
var notes = cursor.element.notes;
nameChord(notes, text, false);
if (text.text)
cursor.add(text);

switch (cursor.voice) {
case 1: case 3: text.placement = Placement.BELOW; break;
}

if (text.text)
text = newElement(Element.STAFF_TEXT) // Make another STAFF_TEXT object

// Finally process trailing grace notes if they exist...
text = renderGraceNoteNames(cursor, trailingFifo, text, true)
} // end if CHORD
cursor.next();
} // end while segment
} // end for voice
} // end for staff

curScore.endCmd()
quit();
} // end onRun
}

for (var chord of chordList) {
var vstaff = curScore.staves[chord.vStaffIdx]
var lines = vstaff.lines(chord.fraction)
var above = (chord.voice % 2 == 0)
var lineScale = vstaff.lineDistance(chord.fraction) * vstaff.staffMag(chord.fraction)
var topline = lineScale * Math.min((chord.bbox.y / lineScale) - 1, -1.5)
var bottomline = lineScale * (Math.max((chord.bbox.y + chord.bbox.height) / lineScale + 1, lines + 0.5) - 4)
var tabStaff = vstaff.isTabStaff(chord.fraction)

for (var i in chord.notes) {
var note = chord.notes[i]
// Attempt to remove old texts
for (var element of note.elements) {
if (element.type == Element.TEXT && /^[A-H](♭|♯)*$/.test(element.text)) {
note.remove(element)
}
}
// list selections / selection filter could be individual notes
if (!note.selected) {
continue
}
// Then apply new names
var text = newElement(Element.TEXT) // This adds the text to the note: Better for grace notes and easier to remove
text.text = nameNote(note)
text.autoplace = false
if (note.noteType != NoteType.NORMAL) {
text.fontSize *= curScore.style.value("graceNoteMag")
}
if (above) {
text.placement = Placement.ABOVE
text.align = Align.BASELINE
text.offset.y = (topline + i * -2)
} else {
text.placement = Placement.BELOW
text.align = Align.TOP
text.offset.y = (bottomline + (chord.notes.length - 1 - i) * 2)
}
text.offset.y -= (tabStaff ? note.string : 0.5 * note.line) * lineScale
note.add(text)
}
}
curScore.endCmd()
quit()
}
}
Loading