Fix crash with hidden staves popup #31367
Open
+15
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: musescore#30934 The "phantom arrows" mentioned in the issue were caused by an unsafe `static_cast` in `rowCount`, casting a `StaffItem` to a `PartItem`, resulting in garbage being read from the resulting `part->staves.size()`. This garbage might be a huge number, causing a huge number of rows to be inserted into the model, to the point that the application (or even the OS) crashes with out-of-memory errors. The `index` method also contains a similar `static_cast`; this one is not problematic, but by principle, I've made this one safe(r) as well. Now we only ever `static_cast` to `Item`, which is justifiable.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30934
The "phantom arrows" mentioned in the issue were caused by an unsafe
static_castinrowCount, casting aStaffItemto aPartItem, resulting in garbage being read from the resultingpart->staves.size(). This garbage might be a huge number, causing a huge number of rows to be inserted into the model, to the point that the application (or even the OS) crashes with out-of-memory errors.The
indexmethod also contains a similarstatic_cast; this one is not problematic, but by principle, I've made this one safe(r) as well. Now we only everstatic_casttoItem, which is justifiable.