Support updating diagrams#2
Open
TruFire wants to merge 2 commits into
Open
Conversation
Contributor
|
I've just merged your PR into my fork at https://github.com/Jojo-Schmitz/harp_pedal_diagram Next step would be to port it to MuseScore 4 ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't get the steps to manually edit the diagram to work (with a, b, c, and d etc.), so this just allows the dialog to open when a pedal diagram element is selected so you can edit it there. However, it does capture the current state in the dialog which makes it easy to change. Updating existing diagrams will only work with diagrams created with the new version of the plugin since I updated the format.