Use SyncedPlayer for drift-corrected playback#1
Merged
maximmaxim345 merged 12 commits intomainfrom Jan 22, 2026
Merged
Conversation
Use sendspin's SyncedPlayer with ClockSync for timestamp-accurate playback synchronized to server time. Replace manual AudioScheduler with command-driven architecture for thread-safe playback control.
# Conflicts: # src-tauri/Cargo.lock # src-tauri/Cargo.toml # src-tauri/src/sendspin/mod.rs
The `[lints.rust]` and `[lints.clippy]` sections were accidentally removed, which disabled `unsafe_code = "forbid"` and clippy pedantic warnings.
The comment said "parking_lot::Mutex" but the code uses TokioMutex.
These structs are deserialized by serde from JSON, not constructed directly in Rust code.
Ports sendspin-rs change: the audio callback needs synchronous locking, not async. TokioMutex is designed for async contexts while parking_lot is more appropriate for real-time audio callbacks.
Required by cpal/sendspin for audio playback on Linux.
- Add backticks to code references in doc comments - Remove redundant `continue` statements - Use `map_or` instead of `map().unwrap_or()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to sendspin's
SyncedPlayerwithClockSyncfor timestamp-accurate playback synchronized to server time.Replaces manual
AudioSchedulerwith a channel-driven architecture where a dedicated thread owns theSyncedPlayer. Clock synchronization now uses Kalman filter-based drift correction via NTP-style timestamp exchange.