Fix XSS via mDNS server name injection in launcher#10
Merged
MarvinSchenkel merged 2 commits intomusic-assistant:mainfrom Feb 18, 2026
Merged
Fix XSS via mDNS server name injection in launcher#10MarvinSchenkel merged 2 commits intomusic-assistant:mainfrom
MarvinSchenkel merged 2 commits intomusic-assistant:mainfrom
Conversation
Replace inline onclick handlers with addEventListener to prevent JavaScript injection through crafted mDNS service names. The escapeHtml() function only escapes HTML element content characters (<, >, &) but not single quotes, which allowed breaking out of the JS string literal in the onclick attribute context. Adds regression test that verifies user-controlled values are never interpolated into HTML attributes and that click handlers use addEventListener instead of inline onclick. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Just some linting issues on the test file. Other than that, another great find, nice fix! |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Fixed, and added a note for myself to always run prettier (thank you!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace inline onclick handlers with addEventListener to prevent JavaScript injection through crafted mDNS service names. The escapeHtml() function only escapes HTML element content characters (<, >, &) but not single quotes, which allowed breaking out of the JS string literal in the onclick attribute context.
Adds regression test that verifies user-controlled values are never interpolated into HTML attributes and that click handlers use addEventListener instead of inline onclick.