Re-resolve output device on each StreamStart#40
Merged
Conversation
The cpal::Device was captured once per WebSocket connection and reused for every CreatePlayer. On macOS with Bluetooth, sleep/reconnect cycles invalidate that handle (CoreAudio assigns a new AudioObjectID), so build_output_stream returned DeviceNotAvailable indefinitely until the WebSocket itself reconnected. The playback thread now takes the configured device id and calls resolve_output_device fresh on each CreatePlayer. Mid-stream device loss is intentionally not auto-recovered — only the user's next play action triggers a re-resolve. Avoids surprise audio re-routing when e.g. AirPods come out mid-song. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Tested for a couple of days, seems to be working well so far. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cpal::Device was captured once per WebSocket connection and reused for every CreatePlayer. On macOS with Bluetooth, sleep/reconnect cycles invalidate that handle (CoreAudio assigns a new AudioObjectID), so build_output_stream returned DeviceNotAvailable indefinitely until the WebSocket itself reconnected. The playback thread now takes the configured device id and calls resolve_output_device fresh on each CreatePlayer.
Mid-stream device loss is intentionally not auto-recovered — only the user's next play action triggers a re-resolve. Avoids surprise audio re-routing when e.g. AirPods come out mid-song.
This is the PR I mentioned when merging #39