Open cask bumps as bot pull requests - #17
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MarvinSchenkel
marked this pull request as ready for review
September 4, 2026 11:27
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
MarvinSchenkel
added a commit
to music-assistant/desktop-app
that referenced
this pull request
Sep 4, 2026
The `update-homebrew` job is wrapped in `if [ -n "$HOMEBREW_TAP_TOKEN" ]`. That secret has never been set, so every release since 0.5.5 printed "HOMEBREW_TAP_TOKEN not set, skipping Homebrew tap update" and reported success. The tap sat six versions behind without anything going red. Rather than adding a PAT that expires and puts us back here, this uses `musicassistant-bot`, the same app that opens the frontend to server release PRs. - Mint a bot token scoped to `homebrew-tap` with `contents: write` and nothing else - Drop the guard, so a missing credential fails the job instead of skipping silently - Replace the bare `curl` with `gh api`, which exits non-zero when the dispatch is rejected Pairs with music-assistant/homebrew-tap#17. Needs `MUSIC_ASSISTANT_BOT_PRIVATE_KEY` granted to this repo before it can run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Marvin Schenkel <marvin.schenkel@openhomefoundation.org> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cask bumps currently push straight to
mainusingGITHUB_TOKEN. Pushes made with that token do not trigger further workflows, sobrew test-botnever runs on them and the cask lands withoutbrew auditor a test install. The 0.6.7 bump earlier today went in with no CI at all.The dispatch that should fire this workflow also never worked:
desktop-appguards it behindif [ -n "$HOMEBREW_TAP_TOKEN" ], the secret is unset, so every release since 0.5.5 logged "skipping" under a green check. That side is fixed in music-assistant/desktop-app#179.Turning on the PR gate immediately found three failures that were already sitting on
mainunnoticed, so this fixes those too.musicassistant-bottoken instead of usingGITHUB_TOKEN, so the PR triggersbrew test-botpeter-evans/create-pull-requestand enable auto-merge, replacing the direct pushenv:and validate it, instead of interpolating attacker-controllable input into the shellset -euo pipefailto the version step and clean up the downloaded tarballsdepends_on :macos, which the generator template never had. Without itbrew stylefailsHomebrew/OSDependsOnandbrew readall --os=allrejects the cask on Linuxverifiedparameter from theurlstanza; Homebrew deprecated it andbrew auditnow fails on it.github/actionlint.yamlsobrew styleacceptsvars.MUSIC_ASSISTANT_BOT_CLIENT_ID. A tap config overrides Homebrew's own, which only declaresBREW_COMMIT_CLIENT_IDpublish.yml;brew pr-pullhas nothing to pull on a cask-only tap and every run of it was skippedbrew style,brew readall --aliases --os=all --arch=allandbrew audit --except=installedall pass locally on this branch.Needs
MUSIC_ASSISTANT_BOT_PRIVATE_KEYgranted to this repo before the workflow can run.🤖 Generated with Claude Code