Skip to content

Automatic updating of the Cask tap#9

Open
sandervankasteel wants to merge 10 commits into
music-assistant:mainfrom
sandervankasteel:feature/scheduled-updating
Open

Automatic updating of the Cask tap#9
sandervankasteel wants to merge 10 commits into
music-assistant:mainfrom
sandervankasteel:feature/scheduled-updating

Conversation

@sandervankasteel
Copy link
Copy Markdown
Contributor

@sandervankasteel sandervankasteel commented Oct 29, 2024

Description

This PR adds to the functionality to automatically update the tap based on the latest Github release.

Note, I've specifically based this PR on a previous version of the repository, for demonstration purposes.

Example commit: sandervankasteel@919614d

Questions / notes :

  • Do pre-releases happen?
    Because that might require some work in the script to prevent issue with releasing pre-release tags.

  • For the moment I've set the schedule to run every 2 hours, but I'm not sure if that's too often or not. Since I do not have any visibility on the CI minute usage of the music-assistant organization

To prevent potentially committing .tar.gz files to be commited into the
repository
@sandervankasteel sandervankasteel force-pushed the feature/scheduled-updating branch 2 times, most recently from 919614d to 3ff3b3d Compare October 30, 2024 11:46
@sandervankasteel sandervankasteel force-pushed the feature/scheduled-updating branch from 3ff3b3d to 4f0454a Compare October 30, 2024 11:47
@sandervankasteel sandervankasteel changed the title [WIP] - Automatic updating of the Cask Automatic updating of the Cask tap Oct 30, 2024
@sandervankasteel
Copy link
Copy Markdown
Contributor Author

sandervankasteel commented Oct 30, 2024

@arctixdev this is ready for review 😊

Edit: The only thing I do not understand is that brew test-bot --only-tap-syntax is failing in the pipeline. Locally it is running as expected.

sander@Sanders-MBP ‹ feature/scheduled-updating ●● › : ~/dev/music-assistant/homebrew-tap
[0] % brew test-bot --only-tap-syntax
==> Using Homebrew/homebrew-test-bot 477f200 (Merge pull request #1276 from Homebrew/dependabot/bundler/sorbet-runtime-0.5.11620)
==> Using Homebrew/brew 4.4.3 (Merge pull request #18639 from Homebrew/improve_parallel_tests)

==> Running TapSyntax#run!
All steps passed!

@sandervankasteel sandervankasteel force-pushed the feature/scheduled-updating branch 3 times, most recently from 9c6ae91 to bcbe118 Compare October 30, 2024 12:04
@sandervankasteel sandervankasteel force-pushed the feature/scheduled-updating branch from bcbe118 to 95009a5 Compare October 30, 2024 12:13
@jonbng
Copy link
Copy Markdown
Member

jonbng commented Oct 30, 2024

Yeah thats weird, I ended up install shellcheck locally and running with the check enabled https://www.shellcheck.net/wiki/SC2312
Now there are some different errors I dont currently have time to look at
In any case, thanks alot for this. From what I saw when quickly looking through this, it looks good

@sandervankasteel
Copy link
Copy Markdown
Contributor Author

different errors I dont currently have time to look at
In any case, thanks alot for this. From what I saw when quick

No problem! I'm glad to help out. If there are any questions or issues, do not hesitate to reach out 😊

@sandervankasteel
Copy link
Copy Markdown
Contributor Author

@jonbng if I update this PR to use the new repository (https://github.com/music-assistant/tauri-companion-app), would it then be possible to get this merged ?

@MarvinSchenkel
Copy link
Copy Markdown
Contributor

@sandervankasteel So sorry about this, Jonathan has been a bit absent and I didn't know we had a brew tap until someone opened an issue in our main repo ;-). I just made all the changes to get the tap working again, if you could make the changes to be compatible with that, I will merge this PR so the cask is automatically updated

@sandervankasteel
Copy link
Copy Markdown
Contributor Author

@sandervankasteel So sorry about this, Jonathan has been a bit absent and I didn't know we had a brew tap until someone opened an issue in our main repo ;-). I just made all the changes to get the tap working again, if you could make the changes to be compatible with that, I will merge this PR so the cask is automatically updated

No worries! I will see what I can do about this in the upcoming few days! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants