Use Split Button on item details screen#127
Merged
formatBCE merged 2 commits intomusic-assistant:mainfrom Feb 26, 2026
Merged
Conversation
seadowg
commented
Feb 26, 2026
| implementation(compose.ui) | ||
| implementation(compose.components.resources) | ||
| implementation(compose.components.uiToolingPreview) | ||
| implementation(libs.material) |
Collaborator
Author
There was a problem hiding this comment.
So it seems like the Compose Multiplatform library setup has changed since this app was kicked off. They know ship separate artifacts instead of attaching the libraries to the multiplatform plugin. This means the compose.* dependencies are currently deprecated, but still working. It's probably worth tidying these all up in a separate PR.
seadowg
commented
Feb 26, 2026
| androidx-test-junit = "1.3.0" | ||
|
|
||
| compose-multiplatform = "1.9.3" | ||
| compose-multiplatform = "1.10.1" |
Collaborator
Author
There was a problem hiding this comment.
I needed to upgrade for the SplitButtonLayout. It's introduced some deprecations in some places (as well as for some dependency declarations as discussed in another comment), but lint/test is happy and everything builds fine.
formatBCE
approved these changes
Feb 26, 2026
Collaborator
formatBCE
left a comment
formatBCE
left a comment
There was a problem hiding this comment.
OMG this looks awesome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy to find out that there was a multiplatform implementation - we just needed to upgrade!