Finish off item page rework#133
Merged
formatBCE merged 10 commits intomusic-assistant:mainfrom Mar 2, 2026
Merged
Conversation
seadowg
commented
Mar 1, 2026
| import androidx.compose.ui.test.onNodeWithTag | ||
| import androidx.compose.ui.test.performScrollToNode | ||
|
|
||
| fun ComposeTestRule.inScrollable(scrollableTag: String, block: ScrollableScope.() -> Unit) { |
Collaborator
Author
There was a problem hiding this comment.
I'm a little shocked there aren't more helpers in Compose's testing libraries to deal with scrolling out of the box.
seadowg
commented
Mar 1, 2026
| @@ -0,0 +1,45 @@ | |||
| package io.music_assistant.client.utils.support | |||
|
|
|||
| abstract class MockFunction { | |||
Collaborator
Author
There was a problem hiding this comment.
I'd usually prefer just rolling my own fakes/mocks than using a framework, but Compose's callback heavy interfaces are an ideal candidate for the latter as you end up with a lot more anonymous function parameters than domain specific interfaces. I had a quick look at KMP safe options (as opposed to using a JVM specific standard like Mockito), and it honestly seemed easier to just quickly roll a utility for ourselves while we let that scene mature.
formatBCE
approved these changes
Mar 2, 2026
Collaborator
formatBCE
left a comment
formatBCE
left a comment
There was a problem hiding this comment.
Thanks for the foundational steps!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108
Work towards #113
This takes care of the rest of the issue:
I played around with different options for the item screen's "landscape" mode and settled on a variation derived from the desktop layout:
This mode kicks in at the "expanded" size class (used for the screenshot), with compact and medium using the more "portrait" oriented layout.