feat(observability): lifecycle markers + cancel-leak fix#316
Merged
Conversation
Adds diagnostic logging across KtorServiceClient and AuthenticationManager
to make stuck-reconnect / stuck-CarPlay sessions traceable from log
captures.
- stateLabel / dcsLabel for compact, grep-stable session-state tags
- Transport state-edge logs (Connected / Reconnecting / Failed / Disconnected)
- isReadyForCommands edge collector
- Explicit "no recovery taken" branch in onAppForeground for the
actually-stuck case (state != Connected, no savedInfo); happy path
stays silent so logs aren't polluted with non-events
- "Reconnect not applicable" branch in onExternalConsumerActive
- sendRequest[msgId] markers: start/sent/resumed at .d (high volume),
cancelled/transport=null at .i (rare, informational)
- AuthMgr per-branch trace via Logger.withTag("AuthMgr")
Bug fix: sendRequest now installs invokeOnCancellation to remove the
rpcEngine callback if the parent coroutine is cancelled (e.g. a caller's
withTimeoutOrNull fires). Without this, never-arriving responses leak
orphaned callbacks for the lifetime of the session.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
formatBCE
approved these changes
May 2, 2026
Collaborator
formatBCE
left a comment
formatBCE
left a comment
There was a problem hiding this comment.
Looks good - let's see how it runs ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a bunch of logging to track down errors over the past few days. These are the ones that I thought were worth shipping to help with issue triaging in the future, along with fixing a small leak in sendRequest.
Robot:
Adds diagnostic logging across KtorServiceClient and AuthenticationManager to make stuck-reconnect / stuck-CarPlay sessions traceable from log captures.
Bug fix: sendRequest now installs invokeOnCancellation to remove the rpcEngine callback if the parent coroutine is cancelled (e.g. a caller's withTimeoutOrNull fires). Without this, never-arriving responses leak orphaned callbacks for the lifetime of the session.