Conversation
…afety - KmpHelper: nullable-on-timeout fetcher contract (5s withTimeoutOrNull), Cancellable + observeReadiness/observeLocalPlayerPresence subscriptions, drilldown fetchers (artist→albums, album→tracks, playlist→tracks). - CarPlay scene: readiness-gated taps with idempotent offline alert, generation counter on the recommendations fetch, type-aware drilldown dispatch, popToRoot before pushing Now Playing to dodge the depth-5 hierarchy crash, one-shot initial Now Playing push on local-player presence. - CarPlayContentManager: drilldown wrappers + mapItems threading. - SiriIntentHandler: nil → empty coalesce on the four search call sites. - Lifecycle markers via OSLog at .default for post-drive sysdiagnose. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
I've re-run the Android tests a couple of times. I think (since I didn't touch any Android code) that it's probably not something I did? But if I'm wrong, I'm happy to fix it. |
formatBCE
approved these changes
May 2, 2026
Contributor
Author
|
I think I found the cause of the android test failures: #321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR with the actual CarPlay reliability fixes that I've been working on. Specifically, we had some forever-hangs that now get timeouts, we add a 'Disconnected' row to the UI if we do get timeouts, and we can now drill down into the actual albums of an artist, etc.