Restore radio_source media objects in PlayerQueue.from_cache#212
Merged
marcelveldt merged 1 commit intomusic-assistant:mainfrom Apr 28, 2026
Merged
Conversation
marcelveldt
approved these changes
Apr 28, 2026
MarvinSchenkel
pushed a commit
to music-assistant/server
that referenced
this pull request
Apr 29, 2026
Update music-assistant-models to version [1.1.116](https://github.com/music-assistant/models/releases/tag/1.1.116) - Revert "Add Recommendations Updated event" (by @MarvinSchenkel in [#214](music-assistant/models#214)) - Restore radio_source media objects in PlayerQueue.from_cache (by @dmoo500 in [#212](music-assistant/models#212)) ## 🚀 Features and enhancements - Add Recommendations Updated event (by @OzGav in [#208](music-assistant/models#208)) - Add artist_type to Artist (by @fmunkes in [#209](music-assistant/models#209)) ## 🧰 Maintenance and dependency bumps <details> <summary>5 changes</summary> - Build(deps): Bump release-drafter/release-drafter from 7.1.0 to 7.2.0 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#204](music-assistant/models#204)) - Build(deps-dev): Bump tomli from 2.4.0 to 2.4.1 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#193](music-assistant/models#193)) - Build(deps): Bump pypa/gh-action-pypi-publish from 1.13.0 to 1.14.0 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#203](music-assistant/models#203)) - Build(deps-dev): Bump pytest from 9.0.2 to 9.0.3 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#206](music-assistant/models#206)) - Build(deps-dev): Bump mypy from 1.20.0 to 1.20.1 (by @[dependabot[bot]](https://github.com/apps/dependabot) in [#211](music-assistant/models#211)) </details> ## 🙇 Contributors @MarvinSchenkel, @OzGav, @dmoo500 and @fmunkes Co-authored-by: marcelveldt <6389780+marcelveldt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a server restart,
PlayerQueue.from_cache()correctly rebuildsenqueued_media_itemsby callingmedia_from_dicton each raw dict from the cache. However,radio_sourcewas not handled the same way — mashumaro deserializes it as plaindictobjects instead of properMediaItemTypeinstances, depending on the version.This causes
isinstancechecks (e.g.isinstance(item, Playlist)) in_fill_radio_tracks()on the server to silently fail after a restart, breaking radio/shuffle playback.Fix
Apply the same
media_from_dictreconstruction toradio_sourceinfrom_cache(), identical to the existing pattern forenqueued_media_items.Fixes music-assistant/server#3766