Switch docker base images to Debian #2542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Docker base images from Alpine Linux to Debian Bookworm, addressing compatibility issues with packages that lack Alpine support. The key change involves building FFmpeg from source within a multi-stage build rather than using pre-built static binaries.
Key changes:
- Multi-stage Docker build that compiles FFmpeg 7.1.2 from source with comprehensive audio codec support
- Migration from Alpine-specific packages (apk) to Debian packages (apt-get) with runtime dependencies
- Dynamic jemalloc library path configuration based on CPU architecture
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile.base | Complete rewrite to use Debian base images with custom FFmpeg build stage and updated runtime dependencies |
| Dockerfile | Removed Alpine-specific wheel repository references and fixed comment typo |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches our docker images to be Debian based as we had too many issues piled up trying to stay on Alpine builds, especially with special packages that provide no alpine builds.
Also we now compile ffmpeg ourselves within the base image build