Fix several edge cases for streaming (with crossfade enabled) #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several edge cases for streaming with crossfade enabled, primarily by renaming DEFAULT_PCM_FORMAT to INTERNAL_PCM_FORMAT and adding better handling for crossfade scenarios with different sample rates and PCM formats.
Key changes:
- Renamed
DEFAULT_PCM_FORMATtoINTERNAL_PCM_FORMATacross the codebase to better reflect its usage as an internal format - Added support for crossfading between tracks with different sample rates through new configuration options
- Improved buffer and stream handling to prevent audio glitches during crossfades with mismatched PCM formats
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| music_assistant/constants.py | Renamed DEFAULT_PCM_FORMAT to INTERNAL_PCM_FORMAT and added new config entry for crossfade with different sample rates |
| music_assistant/providers/universal_group/constants.py | Updated references from DEFAULT_PCM_FORMAT to INTERNAL_PCM_FORMAT |
| music_assistant/providers/squeezelite/player.py | Updated references and added support for gapless playback with different sample rates |
| music_assistant/providers/snapcast/player.py | Updated references from DEFAULT_PCM_FORMAT to INTERNAL_PCM_FORMAT |
| music_assistant/providers/builtin_player/player.py | Updated references from DEFAULT_PCM_FORMAT to INTERNAL_PCM_FORMAT |
| music_assistant/providers/airplay/constants.py | Updated references from DEFAULT_PCM_FORMAT to INTERNAL_PCM_FORMAT |
| music_assistant/helpers/audio.py | Renamed function, improved buffering logic for PCM format mismatches, and simplified resampling function |
| music_assistant/controllers/streams.py | Added crossfade configuration options and improved handling of crossfade edge cases with different PCM formats and sample rates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.