-
-
Notifications
You must be signed in to change notification settings - Fork 207
Added deno for YTMusic Provider #2636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added deno for YTMusic Provider #2636
Conversation
|
Could you remove the entry of uv.lock in the gitignore? This contains a snapshot of the dependencies we use, so it makes sense it changes if you add deno. |
|
I've closed my MR In favor of this. Tested and works fine: |
|
Thanks for the guidance Marvin and thanks for testing the fix Romulo! I have made the uv.lock commit so hopefully that wraps this up nicely. |
|
Thanks @Dnny44 |
* Added deno for YTMusic Provider * Commiting uv lock
|
not sure if I'm doing something wrong. I just downloaded the stable MA add-on update 2.6.3 through the HA updater I tried removing and re-installing the YT Music PO Token Generator add-on |
|
UPDATE REGARDING YT MUSIC: We just released 2.6.3 with the fixes for YT Music. However, the required JS runtime that is used to solve JS challenges for YTM does NOT work with the architecture we use for stable. As of 2.7.0, Music Assistant will use a new base image architecture that does support this. This unfortuantely means that YTM cannot be fixed in the stable channel for now and will only work again starting 2.7.0. YT Music currently only works in the beta releases. |
A JavaScript runtime is now required for the Youtube Music provider to work, deno is the recommended and the default setting on yt-dlp: https://github.com/yt-dlp/yt-dlp/wiki/EJS
This fixes music-assistant/support#4348
There is another Pull Request [https://github.com//pull/2634] for this as well but based on @MarvinSchenkel commit history I think this is the preferred method of adding the dependency.