Add type hints to config controller functions

[marcelveldt]

Add type hints to the config controller functions to get config entry values.
This prevents having to do a lot of type casts everywhere when retrieving config values.

[marcelveldt]

@OzGav FYI - this helps your other PR(s)

[Copilot]

Pull Request Overview

This PR adds type hints to config controller functions to eliminate the need for type casts when retrieving configuration values. The changes introduce overloaded function signatures with a return_type parameter for type inference, along with TypeVar-based type hints for better static type checking.

Key Changes

• Added _ConfigValueT TypeVar bound to ConfigValueType for type inference in config getter functions
• Added overloaded signatures to get_provider_config_value, get_player_config_value, get_core_config_value, and the get_raw_* methods
• Removed explicit type casts throughout the codebase in favor of the new return_type parameter
• Added comprehensive docstrings explaining the new return_type parameter

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
music_assistant/controllers/config.py	Core changes adding TypeVar definition, overload signatures for all config getter methods, and updated docstrings
music_assistant/providers/universal_group/player.py	Removed cast and updated to use return_type parameter with positional argument syntax
music_assistant/providers/squeezelite/provider.py	Removed cast from get_raw_player_config_value call and replaced cast with int() for explicit type conversion
music_assistant/providers/airplay/protocols/raop.py	Removed explicit None default argument and updated to use return_type as keyword argument
music_assistant/controllers/music.py	Removed cast and updated to use return_type as keyword argument

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

[nitpick] The return_type parameter is used purely for type inference and doesn't perform runtime type validation. This means if a caller specifies return_type=str but the actual config value is an int, the type checker will assume it's a str while the runtime value will be an int, potentially causing type safety issues.

Consider adding a note in the documentation to clarify that return_type is for static type checking only and callers are responsible for ensuring the specified type matches the actual config value type. Alternatively, consider adding runtime validation with isinstance() to catch type mismatches early.

[Copilot]

The return_type parameter should be keyword-only (using *, before it) to be consistent with the other config getter methods (get_provider_config_value and get_core_config_value), which both use keyword-only parameters for return_type. This ensures API consistency and prevents potential errors from positional argument ordering.

Additionally, usage in this file should be updated to use keyword argument syntax: return_type=str instead of passing str positionally.

Suggested change

	unpack_splitted_values: bool = False,
	unpack_splitted_values: bool = False,
	*,

[Copilot]

The return_type parameter should be passed as a keyword argument (return_type=str) instead of a positional argument for consistency with similar usages elsewhere in the codebase (e.g., airplay/protocols/raop.py line 67) and to match the API design of other config getter methods.

Suggested change

	child_player_id, CONF_HTTP_PROFILE, False, str
	child_player_id, CONF_HTTP_PROFILE, False, return_type=str

[Copilot]

The overloads don't correctly handle the interaction between unpack_splitted_values and return_type. When unpack_splitted_values=True, the function always returns tuple[str, ...] | list[tuple[str, ...]] (from line 545) regardless of the return_type parameter. The overloads should be structured as:

1. When unpack_splitted_values=True → return tuple[str, ...] | list[tuple[str, ...]]
2. When unpack_splitted_values=False and return_type=type[T] → return T
3. When unpack_splitted_values=False and return_type=None → return ConfigValueType

This requires using Literal[True] and Literal[False] in the overloads to properly discriminate the return type based on the unpack_splitted_values parameter.