Fix: Handle non-UTF8 .lrc files gracefully to prevent playback blocking #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a .lrc (lyrics) file associated with an MP3 has non-UTF8 encoding, the previous code would fail during file reading and potentially block playback. This fix: 1. Explicitly specifies UTF-8 encoding when opening .lrc files 2. Wraps .lrc file reading in try-except block 3. Logs a warning if the lyrics file cannot be read 4. Allows playback to continue even if lyrics parsing fails This ensures that encoding issues in lyrics files are logged but do not prevent the audio file from playing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a .lrc (lyrics) file associated with an MP3 has non-UTF8 encoding, the previous code would fail during file reading and potentially block playback. This fix:
This ensures that encoding issues in lyrics files are logged but do not prevent the audio file from playing.