Fix artist name splitting with semicolons and Vorbis multi-field handling#3390
Open
Fix artist name splitting with semicolons and Vorbis multi-field handling#3390
Conversation
Contributor
OzGav
commented
Mar 14, 2026
- music_assistant/helpers/tags.py:
- Fixed artists and album_artists properties to not split on semicolons when values are already in a list (multiple ARTIST fields from Vorbis)
- Added MB ID count check for singular ARTIST/ALBUMARTIST tags - if count is 1, don't split even on semicolons
- Added warning in _parse_vorbis_artist_tags() for non-standard ARTISTS/ALBUMARTISTS tags in Vorbis files
- Added proper comments with spec references
- tests/core/test_tags.py:
- Added test_vorbis_multiple_artist_fields_semicolon_in_name - mock test for multiple ARTIST fields with semicolon
- Added test_flac_multiple_artist_fields_semicolon_e2e - end-to-end test with real FLAC file
- Added test_id3_artist_tag_semicolon_single_mbid - test for single ARTIST with semicolon and 1 MB ID
- Added test_id3_artist_tag_semicolon_multiple_mbids - test for ARTIST with semicolon and multiple MB IDs
- Added test_id3_albumartist_tag_semicolon_single_mbid - same for album artist
- tests/fixtures/ArtistWithSemicolon.flac:
- New test fixture with multiple ARTIST fields, one containing ave;new
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.