Fix readAll() to only mark received messages as read #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, readAll() would update all message notifications for a participant, including messages they sent. This was unnecessary since sent messages already have is_seen=1 from creation. Now readAll() only updates notifications where is_sender=0, ensuring only received messages are marked as read. This is more efficient and prevents unintended side effects on sent message notifications. Closes #210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
readAll()to only update notifications whereis_sender=0The Problem
When a user called
readAll(), it would mark ALL their message notifications as read, including messages they sent. While sent messages already haveis_seen=1from creation, the update query was still hitting those rows unnecessarily.The Fix
Added
->where('is_sender', 0)condition to the update query so only received messages are marked as read.Test plan
readAll()Closes #210