HTMLEditor: Insert link UI #548
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbucksch
force-pushed
the
master
branch
3 times, most recently
from
871e5e5 to
0f52199
Compare
benbucksch
force-pushed
the
master
branch
5 times, most recently
from
e97466f to
cff88be
Compare
benbucksch
force-pushed
the
master
branch
2 times, most recently
from
496d771 to
cbe1a12
Compare
benbucksch
force-pushed
the
master
branch
3 times, most recently
from
d2ed3e0 to
3fc49e6
Compare
benbucksch
force-pushed
the
master
branch
2 times, most recently
from
7d2a658 to
3640c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new Bubble Menu, I've implemented a small bubble menu that shows up near the selected when you want to insert a link. The UI isn't great and the input field is not focused when the bubble menu shows up. But this is what I propose. I would like a better UI though.
It only works for links now.
To use the extension you would have to configure it like, where you have to pass the element that the editor will attach to because setting up the UI needs to happen before the editor is loaded.