FastList: Wheel event with touchpad: Throttle (#361) #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note that this is a throttle, not a debounce. Debounce would stop and delay execution entirely until you no longer scroll. That would be off. Throttle makes sure we don't call more often than every n milliseconds, with n = 30 ms. |
Collaborator
|
It feels almost the same as before where it scrolls too fast. There’s about 10 scroll events with touchpad compared to 4 scroll events with mouse per scroll. |
benbucksch
force-pushed
the
master
branch
5 times, most recently
from
e97466f to
cff88be
Compare
benbucksch
force-pushed
the
master
branch
2 times, most recently
from
496d771 to
cbe1a12
Compare
benbucksch
force-pushed
the
master
branch
3 times, most recently
from
d2ed3e0 to
3fc49e6
Compare
benbucksch
force-pushed
the
master
branch
2 times, most recently
from
7d2a658 to
3640c13
Compare
Collaborator
|
@benbucksch The Fastest is working perfectly for me now with the new FastList. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jeremy wrote:
There's a little unresponsiveness feeling when using the trackpad compared to a mouse, especially when scrolling slowly. Below is the log I get when using a Trackpad compared to a mouse. The trackpad triggers more events but less deltaY change but the mouse triggers less events but more deltaY.
This PR adds a throttle function for the wheel event, hoping that this will fix the unresponsiveness.