-
Notifications
You must be signed in to change notification settings - Fork 9
Android: Run Node.js in a ViewModel Coroutine #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I don't know where the kotlin and C++ code comes from? |
| exit 0 | ||
| fi | ||
|
|
||
| DOWNLOAD_URL="https://github.com/mustang-im/nodejs-mobile/releases/download/v22.9.0/nodejs-mobile-v22.9.0-android.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, downloading binary blobs is uncool and dangerous. It will get is thrown out of F-Droid (or rejected from), for instance.
It's also against reproducible builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: Put the libs into an npm release.
Then, get them from node_modules/...
Still a binary module, but at least using the normal package installer dependency system, not just fetching it via https.
|
|
||
| // Task 4: Update C++ Files | ||
| async function updateCppFiles() { | ||
| const OLD_JNI_PREFIX = "im/mustang/capa"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that make any difference which package name the code has?
Can we just leave it as-is?
Does a user see the difference?
I understand that stack traces would be different, but that's rather a disadvantage that an advantage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed we're no longer calling any method from Java.
androidx.core:core-ktx:1.17.0would not work