EWS: Unsubscribe all notifications on logout #965 #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Shouldn't you also close the connections from our side? |
Collaborator
|
Make a
|
Collaborator
Author
I can look into doing that.
It was just an example of when you might want to disconnect. |
benbucksch
requested changes
Dec 19, 2025
app/logic/Abstract/Account.ts
Outdated
| * and likely deletes all local information from this account. | ||
| * Does not delete the account on the server. */ | ||
| async deleteIt(): Promise<void> { | ||
| await this.disconnect(); |
Collaborator
There was a problem hiding this comment.
This should be logout()
app/logic/Abstract/Account.ts
Outdated
|
|
||
| /** | ||
| * Used to request that any long-lived connections be disconnected, | ||
| * either due to app shutdown or account deletion. |
Collaborator
There was a problem hiding this comment.
* e.g. due to app shutdown.
Collaborator
There was a problem hiding this comment.
Thanks that you added the function, and documented it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.