Skip to content

Conversation

@jsanford8
Copy link
Contributor

  • Remove ad_watch_time and view_content_watch_time, metrics which do not exist.

Note: The above change may be considered breaking; if you were accessing either field on a base Video View, that will no longer work. It is highly likely that your code was not using those fields, however.

@jsanford8 jsanford8 requested a review from a team as a code owner November 18, 2024 18:46
Copy link
Contributor Author

@jsanford8 jsanford8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but can't approve my own PR

Copy link
Contributor

@philcluff philcluff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsanford8 jsanford8 merged commit 177e2f8 into master Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants