bugfix: chroot_exit_teardown#95
Open
Nschembr wants to merge 1 commit into
Open
Conversation
Description: Ubuntu 24.04.4 LTS Release: 24.04 Codename: noble I'm running live-custom-ubuntu-from-scratch on a desktop host build for testing. I'm in the process of building iso's for automation. I found a minor issue while testing build.sh, chroot_exit_teardown. It looks like proc is needed for the mount command to unmount /sys and /dev/pts. The build script fails to clean up the chroot. I have added export -f to allow the functions to be reused in other scripts. \# test \# ./scripts/chroot is in place \# nested bash needed to keep active shell from closing bash bash \# source the 3 chroot functions (paste in a shell) chroot_enter_setup chroot_enter_debug chroot_exit_teardown The 3 functions can be executed repeatedly without error, and the chroot_enter_debug will have access to networking each time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Ubuntu 24.04.4 LTS
Release: 24.04
Codename: noble
I'm running live-custom-ubuntu-from-scratch on a desktop host build for testing. I'm in the process of building iso's for automation. I found a minor issue while testing build.sh, chroot_exit_teardown. It looks like proc is needed for the mount command to unmount /sys and /dev/pts. The build script fails to clean up the chroot. I have added export -f to allow the functions to be reused in other scripts.
# test
# ./scripts/chroot is in place
# nested bash needed to keep active shell from closing on error
bash
bash
# source the 3 chroot functions (paste in a shell)
chroot_enter_setup
chroot_enter_debug
chroot_exit_teardown
The 3 functions can be executed repeatedly without error, and the chroot_enter_debug will have access to networking each time.