Open
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #188 +/- ##
===========================================
+ Coverage 82.15% 85.28% +3.12%
===========================================
Files 36 33 -3
Lines 1390 1155 -235
===========================================
- Hits 1142 985 -157
+ Misses 248 170 -78
Continue to review full report at Codecov.
|
Author
|
Checking in on this, ping @mvantellingen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings,
This pull request makes a couple of changes to docker-compose to make it safer to use. The values for all environment variables have been removed from
docker-compose.ymland they should, instead, be set in one of two ways:docker-composeis being run fromdocker-compose.yml, which is automatically read bydocker-composeand looks like this:This change makes the docker-compose file generic and allows the end-user to inject their own values without having to change the file.
Additionally, I updated postgres to the official image and verified that it works without any issue. Note: the database name, username, and password environment variables have changed accordingly.