Repository navigation
setup: keep flat-model vision files inside the models directory - #973
Open
mercant1982 wants to merge 1 commit into
Open
mercant1982 wants to merge 1 commit into
mercant1982 wants to merge 1 commit into
Conversation
Fixes mw00#972 Assisted-by: Codex Signed-off-by: Manuel Stehle <338640100+mercant1982@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #972.
When an existing GGUF pack is directly inside --models-dir, the setup currently chooses the model directory's parent for its shared vision folder. For --models-dir /data3 with a retained /data3/maya-ds4 pack, that means /vision.
This change keeps vision inside the configured models directory for that flat layout. The normal nested quant layout keeps its shared sibling vision folder. The initial pack, vision setup and subsequent repack receive the same selected path; EXL3 behavior is unchanged.
CPU before/after on Linux x86_64, base c5842c5:
The regression uses temporary directories and mocked external build/download boundaries. It exercises the real setup path selection and the pack command's --vision argument. No model weights, network request, GPU or production configuration were used or changed. This is a setup-path correction, not a serving or performance change.
Evidence: MAYA972.json; maya972-vision-path.patch.
Reproduction instructions · Evidence bundle and licenses.