Repository navigation
tests: restore mixed-GPU AUTO setting after config checks - #982
Open
mercant1982 wants to merge 1 commit into
Open
mercant1982 wants to merge 1 commit into
mercant1982 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Restore
mixed_gpus.AUTOtogether with the other patched globals intest_auto_where_found.On v1.1.62, the released default is
AUTO=True, but the test'sfinallyblock restores the saved value and then unconditionally sets it toFalse. A successful test therefore leaks a different default into later tests. SavingAUTObefore entering thetryalso makes cleanup independent of how far the test gets.This changes one test file only; no engine or frontend runtime source changes.
Answers
Test-only change: no runtime setting changes. No inference or token comparison was run.
Tested on
Linux x86_64, Lenovo P620, Threadripper PRO 5975WX, 512 GiB RAM, Python 3.12.15. The host has two CMP170HX 64 GiB cards, but neither GPU was used.
Base: v1.1.62,
30145b8b97b2414e2ea91d9f53acbec58a82caf3.Before/after:
test_auto_where_found, then assert thatmixed_gpus.AUTOequals its entry value: before fails (True -> False); after passes (True -> True). The test itself passes in both revisions.python -m unittest serve.test_mixed_gpus serve.test_glm_link -v: 12 passed before and after, no skips.python tools/check_hip_compat.py: passes on the candidate.The CUDA-only checks cover frontend configuration gating; they do not qualify a CUDA build, inference, performance or AMD hardware.
Speed (if this is a speed change)
Not a speed change. No GPU benchmark or model load.
Checks
No CUDA/HIP build was run; the change is Python test cleanup. No user setting or runtime behaviour changes, so no documentation update is needed.
Before/after evidence, probes and reproduction instructions.