Refactor: Add support for CleanMyMac 5 paths and research tools#1
Open
chakravartiraj wants to merge 1 commit intomwangaben:mainfrom
Open
Refactor: Add support for CleanMyMac 5 paths and research tools#1chakravartiraj wants to merge 1 commit intomwangaben:mainfrom
chakravartiraj wants to merge 1 commit intomwangaben:mainfrom
Conversation
Problem: The original patch script was version-locked to CleanMyMac X 4.11.4 and failed on systems with CleanMyMac 5 installed due to hardcoded paths and signature mismatches. Actions: - Updated 'patch.py' to automatically detect both version 4 (MAS) and version 5 paths. - Updated 'verify.sh' to check codesign for version 5 binaries. - Introduced 'search_hex.py' and 'search_wildcard.py' for easier signature discovery in newer versions. - Updated 'README.md' to document dual-version support and clarify version lock for patching logic. Root-cause: Version 5 uses a fundamentally different directory structure and modular framework architecture compared to version 4, rendering the original MAS-specific paths obsolete. Solution: Implementation of dynamic path detection allows the script to function (at least for detection) across both major versions, while new research tools provide a foundation for future signature updates. Verification: Manual verification confirmed 'patch.py' correctly identifies CleanMyMac 5 paths. Codesign verification via updated 'verify.sh' confirmed original binaries are valid before patching attempts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The original patch script was version-locked to CleanMyMac X 4.11.4 and failed on systems with CleanMyMac 5 installed due to hardcoded paths and signature mismatches.
Actions:
Root-cause:
Version 5 uses a fundamentally different directory structure and modular framework architecture compared to version 4, rendering the original MAS-specific paths obsolete.
Solution:
Implementation of dynamic path detection allows the script to function (at least for detection) across both major versions, while new research tools provide a foundation for future signature updates.
Verification:
Manual verification confirmed 'patch.py' correctly identifies CleanMyMac 5 paths. Codesign verification via updated 'verify.sh' confirmed original binaries are valid before patching attempts.