Fix tick labels disappearing with FacetGrid.set_<x|y>ticklabels#3926
Open
JustinVanHeek wants to merge 3 commits into
Open
Fix tick labels disappearing with FacetGrid.set_<x|y>ticklabels#3926JustinVanHeek wants to merge 3 commits into
JustinVanHeek wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3341
When
sharexorshareyis true, only the bottom or left axes get the tick labels. This causes issues whenset_xticklabelsorset_yticklabelsis called without labels (a common case is using therotationargument to rotate the current labels) and can result in those axes losing their tick labels.This PR resolves this issue by getting the current tick labels before any operations occur.Edit: Upon further investigation for cases withshare<x|y>=<"col"|"row">and the discovery of a related bug whenset_xticklabelshas thestepargument, the solution has been updated.This PR resolves this issue by ensuring only the relevant axes are modified. It also ensures the correct number of ticks are selected by slicing the original sequence of ticks when
set_xticklabelshas thestepargument.Related: #1716 #1598