Fix histogram binwidth edge case#3961
Open
ShiroKSH wants to merge 1 commit into
Open
Conversation
Author
|
@mwaskom We'd appreciate it if you could take a look at this pull request when you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3646.
Hist._define_bin_edgescurrently rounds a valid positivebinwidthto zero bins whenever the data range is less than half the requested width. Bothhistplotandobjects.Histthen pass zero to NumPy and raise aValueError.Keep the existing approximate-width behavior, but use one bin when a finite positive width would round to zero. For constant data, provide a one-width range so singleton histograms preserve the requested width, matching the earlier #2813 behavior. Invalid negative widths remain rejected.
Tests:
uv run pytest -q tests/_stats/test_counting.py tests/test_distributions.py tests/test_objects.py(292 passed, 1 skipped)uv run ruff check seaborn/_stats/counting.py tests/_stats/test_counting.pyuv run ty check