Fix negative margin expansion in rugplot causing clipped histogram bars#3962
Open
ananyaparihar wants to merge 1 commit into
Open
Fix negative margin expansion in rugplot causing clipped histogram bars#3962ananyaparihar wants to merge 1 commit into
ananyaparihar wants to merge 1 commit into
Conversation
expand_margins used the signed height value directly, causing negative heights (used for below-axis rugs with clip_on=False) to shrink axis margins instead of expanding them. This clipped marginal histogram bars in jointplot. Fixes mwaskom#3890.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3890
plot_rug's margin expansion usedheightdirectly rather than its absolute value. When a negativeheightis passed (common when drawing rugs below the axis withclip_on=False), this shrank the axis margins instead of expanding them — clipping marginal histogram bars injointplot.Confirmed with the issue's reproduction case: before the fix,
ax_marg_xylim shrank from(0, 50.4)to(12, 36)after adding the rug; after the fix, it correctly expands to(0, 64.8).Ran the full test suite for this file — all relevant tests pass. Two unrelated pre-existing failures occur due to a local Tk/Tcl backend issue, unrelated to this change.