Fix: "Unable to retrieve the file_size" on file upload (Filament 5 / Livewire)#21
Open
xchimx wants to merge 1 commit intomwguerra:mainfrom
Open
Fix: "Unable to retrieve the file_size" on file upload (Filament 5 / Livewire)#21xchimx wants to merge 1 commit intomwguerra:mainfrom
xchimx wants to merge 1 commit intomwguerra:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where successful file uploads are logged and treated as errors, throwing
Unable to retrieve the file_size for file at location: livewire-tmp/....Root Cause
With recent Livewire versions (especially noticeable after upgrading to Filament 5), temporary files are moved/deleted immediately upon calling
$file->storeAs().Because the
Log::infoblock directly afterstoreAs()tried to fetch$file->getSize()and$file->getMimeType()from the temporarylivewire-tmppath, Flysystem threw aUnableToRetrieveMetadataexception.Solution
I simply reordered the logic to retrieve the file metadata (
sizeandmime_type) beforestoreAs()is executed. This prevents the exception and allows the upload flow to complete successfully.