Run convert_project in a distinct working directory. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should detect if anything run by convert_project inappropriately assumes that the working directory is the same as one of the other important directories involved (the source directory, build directory, etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should detect if anything run by convert_project inappropriately assumes that the working directory is the same as one of the other important directories involved (the source directory, build directory, etc.).
Example: With correctcomputation/checkedc-clang#488 modified to use the original
getCanonicalFilePath(which may assert when the working directory differs from thedirectoryfield in the compilation database: details), we now see the failure in vsftpd. Previously it was masked because the workflow set the working directory to the project base directory, which equals the compilation databasedirectoryfield in the case of vsftpd.