Follow-up: -w flag, negative tests, and test cleanup#6
Merged
Conversation
Atomic via temp file in the same directory plus os.Rename, preserving the original file mode.
Cover the cobra ExactArgs(1) rejection and the missing-path error path through internal.ProcessFile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes that were missed when PR #5 was merged without pushing the local branch:
-w/--writeflag tolitdoc filefor in-place rewrite via atomic temp+rename, preserving file mode.TestMain,runScript) fromfile_test.gointotestscript_test.go.Notes for reviewers
-wwrites atomically: temp file in the same directory, chmod to preserve mode, thenos.Rename.litdoc filebeyond adding the flag.Checklist before requesting a review
If any of these checks are missing, please provide an explanation.