Skip to content

Conversation

@mwouts
Copy link
Owner

@mwouts mwouts commented May 31, 2025

Fixes #386

@mwouts mwouts requested a review from Copilot May 31, 2025 12:03
@github-actions
Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@fix_386

(this requires nodejs, see more at Developing ITables)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #386 by allowing an optional final semicolon in style strings.

  • Adds tests to validate the new behavior of allowing a trailing semicolon.
  • Updates the get_expanded_style function to filter out empty style segments.
  • Updates the changelog to document the feature change.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/test_javascript.py Adds tests for get_expanded_style covering the final semicolon.
src/itables/javascript.py Refines style expansion logic to ignore empty segments from trailing semicolon.
docs/changelog.md Updates the changelog to mention support for an optional final semicolon.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (6da378b) to head (2d157aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   88.91%   89.05%   +0.13%     
==========================================
  Files          44       44              
  Lines        1832     1837       +5     
==========================================
+ Hits         1629     1636       +7     
+ Misses        203      201       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts mwouts merged commit a8ea92e into main May 31, 2025
15 checks passed
@mwouts mwouts deleted the fix_386 branch May 31, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when parsing style string (regression from v2.3)

3 participants