Skip to content

Conversation

@emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR fixes the missing exceptions in src/itables/javascript.py.

Signed-off-by: Emmanuel Ferdman <[email protected]>
@github-actions
Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/emmanuel-ferdman/itables.git@main

(this requires nodejs, see more at Developing ITables)

@mwouts mwouts added this to the 2.4.1 milestone May 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.05%. Comparing base (149947d) to head (bf680d0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/itables/javascript.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (91.38%) is below the target coverage (93.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files          44       44           
  Lines        1836     1836           
=======================================
  Hits         1635     1635           
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts
Copy link
Owner

mwouts commented May 31, 2025

Thank you @emmanuel-ferdman for this fix! I'm quite surprised to see that ruff or the other QA tools did not catch this, but many thanks anyway!

@mwouts mwouts merged commit 8385779 into mwouts:main May 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants