Skip to content

Conversation

@mwouts
Copy link
Owner

@mwouts mwouts commented May 31, 2025

No description provided.

@mwouts mwouts requested a review from Copilot May 31, 2025 16:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow to grant the GITHUB_TOKEN the necessary permissions for Pages deployments.

  • Added a permissions block granting write access to pages and id-token.
  • Introduced an environment configuration for the github-pages deployment.

@github-actions
Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@fix_deploy

(this requires nodejs, see more at Developing ITables)

@mwouts mwouts merged commit 78944b0 into main May 31, 2025
14 checks passed
@mwouts mwouts deleted the fix_deploy branch May 31, 2025 16:03
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.27%. Comparing base (0d12624) to head (998b666).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          44       44           
  Lines        1836     1836           
=======================================
  Hits         1639     1639           
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants