Skip to content

Conversation

@mwouts
Copy link
Owner

@mwouts mwouts commented Aug 29, 2025

Closes #429

@github-actions
Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@itables_config

(this requires nodejs, see more at Developing ITables)

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.03%. Comparing base (718c6e5) to head (dcb3267).

Files with missing lines Patch % Lines
src/itables/config.py 75.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   88.16%   88.03%   -0.14%     
==========================================
  Files          50       52       +2     
  Lines        2028     2106      +78     
==========================================
+ Hits         1788     1854      +66     
- Misses        240      252      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts mwouts merged commit b140429 into main Aug 29, 2025
15 checks passed
@mwouts mwouts deleted the itables_config branch August 29, 2025 22:36
except ImportError:
import tomli as tomllib # pyright: ignore[reportMissingImports]

from platformdirs import user_config_path
Copy link

@daureg daureg Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platformdirs should be added as a dependency:

git clone https://github.com/mwouts/itables.git
cd itables
uvx hatch test
ImportError while loading conftest '/home/glefalher/nwork/itables/tests/conftest.py'.
tests/conftest.py:4: in <module>
    from itables.sample_dfs import PANDAS_VERSION_MAJOR, get_dict_of_test_dfs
src/itables/__init__.py:1: in <module>
    from itables import config, downsample, options, sample_dfs
src/itables/config.py:24: in <module>
    from platformdirs import user_config_path
E   ModuleNotFoundError: No module named 'platformdirs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement an ITables configuration file

4 participants